[#120] add ticket attributes and iterator function#803
[#120] add ticket attributes and iterator function#803d-w-moore wants to merge 5 commits intoirods:mainfrom
Conversation
|
Marked ready for review. |
d-w-moore
force-pushed
the
120.m.new
branch
2 times, most recently
from
dbaafa9 to
4ffb324
Compare
|
Have seen a completely passing test run for iRODS 4.3.5. |
d-w-moore
force-pushed
the
120.m.new
branch
2 times, most recently
from
d3c56b2 to
dd27b39
Compare
|
Per discussion earlier today, ignoring remaining ruff alerts |
korydraughn
left a comment
korydraughn
left a comment
There was a problem hiding this comment.
Looking real good. Just one comment about the README.
Once that's addressed, I think we'll be ready to merge this.
README.md
Outdated
|
|
||
| The above should produce a listing fairly close to what one would expect from `iticket ls`. | ||
|
|
||
| How can a rodsadmin selectively access "orphan" tickets (those no longer owned by any user)? |
There was a problem hiding this comment.
Let's turn this into a subsection and adjust the wording to not be a question.
For example ...
### Removing orphan ticketsThere was a problem hiding this comment.
Let's turn this into a subsection and adjust the wording to not be a question.
For example ...
### Removing orphan tickets
Ok, done. Pausing for re-evaluation ... will resolve when you've reviewed the updated text.
There was a problem hiding this comment.
Updated text looks good to me.
alanking
left a comment
alanking
left a comment
There was a problem hiding this comment.
Just had one thing from previous PR.
3 participants
By default the new
ticket_iteratorfunction provides a generator over all tickets viewable from the current user's session. The aperture of the query can however be limited using thefilter_argsparameter.Also: If a query
resultmatching theticketparameter is furnished to theTicketconstructor, the Ticket object can be populated with the members ofirods.models.TicketQuery.Ticketfrom the relevant Ticket object columns - this usage of course corresponds to an already existing iRODS ticket.Note that this PR adds
create_timeandmodify_time(both UTCDateTimeobjects) to the columns returned from the unfiltered query.The old usage, letting the
resultparameter default toNone, is still useful for creating tickets as well as for supplying them for use in the current session, regardless of whether the ticket is available by querying to the session's authenticated user.this PR supercedes #800